This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Cleanup and hotfixes #3306
Merged
Cleanup and hotfixes #3306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
This |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
cc @mxstbr - I'm hot shipped a change to the thread param redirect: cf554b8
This update will cause anyone who hits a
?t=link via SSR (e.g. coming in from spectrum externally) will just get pushed to the thread view, versus landing in the dashboard in us figuring out which thread to load. This is because SSR is somehow triggering a re-render which breaks the persistence of the?t=in the dashboard for people who come in via SSR, so they never hit the thread they expect.All the other things I'm piggybacking in because they are super small requests from users :)