This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Join and leave communities from mobile app #3311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #3252
|
Added the new Button component and switched up the behavior: this is a touch unfinished, but I really need the work from #3301 to ship so I can clean this up. Basically I'd like the experience to be that the button to join is only visible for non members, and if you join the community it changes to a 'leave' button - but only during that session. If you revisit the community profile there shouldn't be a huge 'leave' button at the top of the screen - I'd like to put it inside a 'Details' view similar to how the thread details view works in #3301. So: shipping this, then I'll ship #3312, then I'll get #3301 ready to go, and then tomorrow I'll implement the community and channel details views :) |
brianlovin
approved these changes
Jun 13, 2018
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know any existing issue(s) that could be related to this PR)
Closes #3252