Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Conversation

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Jun 21, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • mobile

Related issues (delete if you don't know of any)
Closes #3321

Currently broken due to an error saying "Requiring module 'fetch' which threw an error: 'TypeError: undefined is not an object'"". Potentially related to expo/sentry-expo#31

TODO

@mxstbr
Copy link
Contributor Author

mxstbr commented Jun 21, 2018

@Kureev could we get some guidance on how to move from getProjectRoots to getProjectRoot/getWatchFolders? I tried in 313f473 but unfortunately that throws an error on startup saying Unable to resolve "../shared/theme" from "App.js".

For context, we have a monorepo that's laid out like this:

spectrum/
├── shared/   # Shared JS utils
├── mobile/   # Mobile client
└── src/      # Web client

In mobile/, we have stuff like import { someUtil } from '../../../shared/utils'. Previously, we used getProjectRoots to make that work.

I tried setting the new getProjectRoot to the root spectrum/ folder, (assuming that would do the trick) but unfortunately it throws that error when trying to import anything from shared/.

How can we make this work again?

@mxstbr
Copy link
Contributor Author

mxstbr commented Jun 25, 2018

Huh this is super weird, I come back after the weekend, revert that commit and now everything works, even Sentry 🤔 🤔 🤔

@brianlovin
Copy link
Contributor

Super weird. Let's do it!

@mxstbr mxstbr merged commit ef737af into alpha Jun 25, 2018
@mxstbr mxstbr deleted the update-mobile-expo-sdk branch June 25, 2018 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants