This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Enable Apollo Engine again and cache Community.metaData #3778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets Engine up to cache public responses in the server memory, and sets up the cache directive for Community.metaData. This is obviously not optimal as we want the cached result to be returned by all servers, not every server having to cache! Future TODO
brianlovin
approved these changes
Aug 16, 2018
|
Yep sounds good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
This sets Apollo Engine up again and makes it cache public responses in the server memory.This is obviously not optimal as we want the cached result to be returned by all servers, not every server having to cache! Not sure yet what to do about that because they don't support Redis, only memcached...
It also sets up the cache directive for Community.metaData, which should theoretically mean we only recompute that every 30 mins or so.