Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Hide pricing link on signed out navbar #3781

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Hide pricing link on signed out navbar #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c9f98
Hide pricing link on signed out navbar
brianlovin Aug 16, 2018
ff71224
Fix tests
brianlovin Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions cypress/integration/navbar_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ const checkSignedOutNavbarRenders = () => {
cy.get('[data-cy="navbar-explore"]').should('be.visible');

cy.get('[data-cy="navbar-support"]').should('be.visible');

cy.get('[data-cy="navbar-pricing"]').should('be.visible');
};

const checkSignedOutSplashNavbarRenders = () => {
Expand All @@ -67,9 +65,6 @@ const checkSignedInSplashNavbarRenders = () => {
cy.visit('/about');
checkSignedInSplashNavbarLinksRender();

cy.visit('/pricing');
checkSignedInSplashNavbarLinksRender();

cy.visit('/features');
checkSignedInSplashNavbarLinksRender();

Expand Down
9 changes: 0 additions & 9 deletions src/views/navbar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
ProfileDrop,
ProfileTab,
SupportTab,
PricingTab,
Tab,
Label,
Navatar,
Expand Down Expand Up @@ -297,14 +296,6 @@ class Navbar extends React.Component<Props, State> {
<Icon glyph="like" />
<Label>Support</Label>
</SupportTab>
<PricingTab
{...this.getTabProps(history.location.pathname === '/pricing')}
to="/pricing"
data-cy="navbar-pricing"
>
<Icon glyph="payment" />
<Label>Pricing</Label>
</PricingTab>
<SigninLink to="/login">Sign In</SigninLink>
</Nav>
);
Expand Down
12 changes: 4 additions & 8 deletions src/views/navbar/style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ export const Nav = styled.nav`
${props =>
props.loggedOut &&
css`
grid-template-columns: repeat(4, auto) 1fr auto;
grid-template-areas: 'logo explore support pricing . signin';
grid-template-columns: repeat(3, auto) 1fr auto;
grid-template-areas: 'logo explore support . signin';

@media (max-width: 768px) {
grid-template-columns: auto auto auto auto;
grid-template-areas: 'home explore support pricing';
grid-template-columns: repeat(3, 1fr);
grid-template-areas: 'home explore support';
}
`} ${props =>
props.hideOnMobile &&
Expand Down Expand Up @@ -277,10 +277,6 @@ export const SupportTab = styled(Tab)`
grid-area: support;
`;

export const PricingTab = styled(MessageTab)`
grid-area: pricing;
`;

export const NotificationTab = styled(DropTab)`
grid-area: notifications;

Expand Down