This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Properly guard generating thread meta images #3809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the Twitter preview from looking shit if the thread meta image fails to generate for whatever reason
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know of any)
Related to #3808 (does not fix it though)
This prevents the Twitter preview from looking shit if the thread meta image fails to generate for whatever reason. This is what it looks like right now if it fails to generate:
Not very nice lol. This patch makes it so we don't show the
summary_large_imagecard if we don't have a large image, basically.