This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Small UI copy changes #3832
Merged
Small UI copy changes #3832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Visit community" was pretty unclear for users, since they were "already viewing the community?!" This makes it obvious that you visit the landing page of the community.
Previously it was impossible to discern whether you had selected a channel or were hovering it because they had the same color. This fixes it by setting a unique hover color by default. In the future, this could even be the community's own selected "brand color".
brianlovin
reviewed
Aug 24, 2018
| <ChannelListItem> | ||
| <Icon glyph={'link'} size={24} /> | ||
| <CommunityListName>Visit community</CommunityListName> | ||
| <CommunityListName>Visit landing page</CommunityListName> |
There was a problem hiding this comment.
"landing page" feels a bit weird, too. What about "View community home" or something?
brianlovin
approved these changes
Aug 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Based on feedback from users this contains two fixes: