This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Add reputation information back to digest emails #4294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #2846, reworks the reputation copy in digest emails and adds it back in.
brianlovin
suggested changes
Nov 21, 2018
|
Sure, feel free to push to your liking! |
|
Yes that "!" was on purpose |
|
@brianlovin latest commit tones it down, if you're happy with this let's ship it and iterate later! |
|
Perfect, thank you! Small nit: could you update the snapshots so future tests don't fail? |
|
Arg forgot to update the snapshots! |
brianlovin
approved these changes
Nov 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know of any)
Based on #2846
Reworks the reputation copy in digest emails, adds tests for it and adds the information back into the digest emails!