Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Conversation

@mxstbr
Copy link
Contributor

@mxstbr mxstbr commented Nov 21, 2018

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

Related issues (delete if you don't know of any)
Closes #

When clicking the "Compose" button on mobile on either a community or channel view the right community and/or channel are now pre-selected automatically.

This is done by passing the active community's and active channel's slug via two query params in the URL, e.g.

/new/thread?activeCommunitySlug=spectrum&activeChannelSlug=general

When clicking the "Compose" button on mobile on either a community or
channel view the right community and/or channel are now pre-selected
automatically.

This is done by passing the active community's and active channel's
slug via two query params in the URL, e.g.

/new/thread?activeCommunitySlug=spectrum&activeChannelSlug=general

Boom
@spectrum-bot
Copy link

spectrum-bot bot commented Nov 21, 2018

Warnings
⚠️

These modified files do not have Flow enabled:

  • src/views/titlebar/index.js

Generated by 🚫 dangerJS

Copy link
Contributor

@brianlovin brianlovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent find and fix man, this will be super useful

@brianlovin brianlovin merged commit 9164958 into alpha Nov 21, 2018
@brianlovin brianlovin deleted the fix-mobile-composer-community-selection branch November 21, 2018 17:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants