This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Add userIdAndIsMember index to usersCommunities table #4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the most high-trafficed tables, and this is the only query in the API that's expensive since it's batched and does a `.filter`. Fixed by adding a new index `userIdAnIsMember` and made even faster by using `.count` instead of `.reduce`! 🎉
brianlovin
approved these changes
Nov 22, 2018
|
Cursory approval, but the fact that e2e failed and also #4308 e2e failed tells me that something is actually failing :P |
…rs-communities-index
|
Hopefully that merge fixes the tests! Then can merge and will run migrations tomorrow |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the most high-trafficed tables, and this is the only query in the API that's expensive since it's batched and does a
.filter.Fixed by adding a new index
userIdAnIsMemberand made even faster by using.countinstead of.reduce! 🎉Status
Deploy after merge (delete what needn't be deployed)
Run database migrations (delete if no migration was added)
YES
Related issues (delete if you don't know of any)
I accidentally based this on #4308, so until that's merged you'll also see those changes here. If you don't want #4308 but you do want this then I'll split this out!