This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Use threadIdAndTimestamp index in mercury db query #4352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Untested
brianlovin
approved these changes
Nov 27, 2018
|
I hope you tested this... 😅 |
|
Whoops sorry didn't read your comment - the code looks good, but I'll try to test locally as well (I'm sure you tried, too?) |
|
No I had a call so as I said, I haven't tested this yet... 😅 |
|
The hard ones to test are daily and weekly counts, just since it would require doing some local kung-fu to warp time. However, my initial tests with |
|
Ace |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Untested
Status
Deploy after merge (delete what needn't be deployed)
@brianlovin I'm not sure how to test whether this returns the exact same result, can you help me with that?