Fix presigned images in thread body

[brianlovin]

Status

• WIP
• Ready for review
• Needs testing

Deploy after merge (delete what needn't be deployed)

• api

@mxstbr this is a stopgap fix for #4667 - we should ship this anyways. It follows your advice of just handling the fix at the query layer. We detect if we stored an imgix url in the thread body, strip the query params, and re-sign it. I confirmed that this works locally.

A followup PR I can work on tomorrow if you approve this is to implement the rest of the steps in #4667 to make sure we don't store signed images in the db during publish or edit.

[mxstbr]

Workaround LGTM, just have to fix CI!

[brianlovin]

Fixed - we just have to fallback to a bad src in case url.parse() fails for whatever reason

[mxstbr]

LGTM if we are sure that the fallback behaviour can not be abused for malicious purposes!

[brianlovin]

LGTM if we are sure that the fallback behaviour can not be abused for malicious purposes!

Afaik this isn't possible, the fallback will only be sent to the client if url.parse(...).pathname returns undefined or null