Post new threads to watercooler as links #4684
Conversation
|
What happens if the thread gets deleted later? Do we leave the dead link? |
This is probably the better option, but hard to do purely through the backend without passing through the entire graphql resolver args. But that way we at least have consistent logic for adding messages. |
|
|
Not too concerned about leaving the dead link either I suppose - the thread preview won't load anyways |
|
Exactly 👍 |
We can use this refactored `addMessage()` method to add messages programmatically while skipping all the permission checks and stuff like that! /cc @brianlovin can you give this a good review to make sure this makes sense?
|
Latest commits refactor the @brianlovin want to give this a good review and test to make sure I did not mess anything up? Otherwise this would basically be ready to ship, pending #4683. |
|
Also changed the posted message to:
How's that look? Would you prefer we add a |
Hm, honestly not a fan of the latest implementation there - it just feels like this weird middleground between being a system-message and looking like a user actually typed it. I think I'd be surprised if I saw that show up in a chat feed when I published a thread. I think the simplest thing here that helps a tiny bit is to just have it only post the link, or maybe just "New thread: {url}" - simple, and doesn't add any expressiveness that might be misconstrued as the user's. A bot label would help here, but maybe the simplest thing actually is to just create SAM and have SAM post the message. That way it has its own name and we could add a [bot] badge to it...not sure how this would work with private communities or private channels, or if permissions matter for a bot like this. Either way, I think we're close but not quite there on making this feel right. |
|
Agreed on those thoughts, I think this was the wrong direction. Latest commit adds a migration for the
What do you think about that? |
|
Will this @ mention trigger a notification to the thread publisher? Ideally it wouldn't, since that would be bit annoying. |
|
Otherwise, I'm much happier with this implementation and then we can just find a good profile photo for Sam |
|
Although maybe instead of Sam we should actually just call it 'Spectrum Bot' for now, to align with the username and not cause any confusion about the user |
|
Awesome! I will confirm re: notification but I do not think it will with the way I have split up /cc @superbryntendo do we have a nice profile photo for Sam somewhere? |
|
It does not trigger a notification, and the latest commit renames the bot to Spectrum Bot! |
|
@mxstbr here's the SAM profile photo Bryn made a while back: https://www.dropbox.com/s/znxozpr359anmk2/SAM%20Button.png?dl=0 |
|
@mxstbr I put that on S3, you should be able to set the profile photo as 'default_images/sam.png' and imgix will handle the rest! |
|
Nice, done! 😍 This is what Sammy looks like now:
Might need to get a round version of the profile photo, but that can be fixed with a quick S3 upload—which means this is ready once #4683 is ready! |
|
Whoa why are those edges getting cropped like that? A square profile photo shouldn't have this problem in the first place... |
|
To expedite this, I went ahead and uploaded a round profile photo...really confused why a square one would get cropped like that though. Once we merge #4683 (pending a small merge conflict if you can grab it!) let's ship this today. |
Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know of any)
Together with #4683 this will get us very close to the "activity feed" concept we want to get to.
Questions
addMessagemutation?