Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

fix: popper menu can't be hide on iOS safari & remove gray backgroud when click #4694

Merged
merged 1 commit into from
Feb 20, 2019
Merged

fix: popper menu can't be hide on iOS safari & remove gray backgroud when click #4694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/components/outsideClickHandler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,19 @@ type Props = {
class OutsideAlerter extends React.Component<Props> {
wrapperRef: React.Node;

// iOS bug, see: https://stackoverflow.com/questions/10165141/jquery-on-and-delegate-doesnt-work-on-ipad
componentDidMount() {
// $FlowFixMe
document.addEventListener('mousedown', this.handleClickOutside);
document
.getElementById('root')
.addEventListener('mousedown', this.handleClickOutside);
}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will cause full screen flash with gray backgroud


componentWillUnmount() {
// $FlowFixMe
document.removeEventListener('mousedown', this.handleClickOutside);
document
.getElementById('root')
.removeEventListener('mousedown', this.handleClickOutside);
}

setWrapperRef = (node: React.Node) => {
Expand Down
1 change: 1 addition & 0 deletions src/reset.css.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ injectGlobal`
padding: 0;
margin: 0;
-webkit-font-smoothing: antialiased;
-webkit-tap-highlight-color: rgba(0,0,0,0);
Copy link
Author

@tuoxiansp tuoxiansp Feb 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fix the gray background
see: https://github.com/twbs/bootstrap/blob/ff29c1224c20b8fcf2d1e7c28426470f1dc3e40d/dist/css/bootstrap.css

font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Helvetica, Arial,
sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol';
}
Expand Down