feat: Add button to hide thread upsell #4708
Conversation
When closed, the action related to the upsell becomes available through a floating button
Generated by 🚫 dangerJS |
|
Do I need to add |
|
@arthurdenner do not worry about it, you are solid! 👍 Going to defer to @brianlovin for a UI review here |
src/components/upsell/joinChannel.js
Outdated
| <FloatingButton | ||
| loading={isLoading} | ||
| onClick={!currentUser ? this.login : this.toggleSubscription} | ||
| icon={!currentUser ? 'door-enter' : 'plus'} |
There was a problem hiding this comment.
Maybe we should add the door-enter icon to the Login or sign up button as well now.
|
@arthurdenner pulled this locally and started trying to make things feel good, but the more I worked on this the more I realized how much we can simplify this. Most of the content in that upsell is repetitive, and we're getting too weird with having to dismiss it. My last commit simplifies everything to just a floating button - want to pull that and take a look? |
|
Hey, @brianlovin, I'm glad you simplified the UI, it's way better now. I'd just suggest to remove the |
|
Agreed, good catch! Let's ship this :) |
|
Thanks again for getting the momentum going here @arthurdenner :) |
3 participants
When the upsell is closed, the action related to it becomes available through a floating button.
Status
Deploy after merge (delete what needn't be deployed)
Related issues (delete if you don't know of any)
Closes #4531.