Skip to content
This repository was archived by the owner on Oct 11, 2022. It is now read-only.

Conversation

@brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

Closes #4743

This fixes a nasty bug where DMing someone from their user profile on mobile would not actually take you to the new message composer screen. The root cause of this issue was that we added a /messages/new route into src/routes.js - in the DM view, we were checking for match.params.threadId and seeing if threadId === 'new' to determine if we should show the composer or not. But since /messages/new does not pass any match.params, this was failing.

I've cleaned up that logic by removing the unneeded route entirely. @mxstbr a future iteration here - which isn't high priority right now - is to support /messages/new as a modal route so that you can initiate a DM from anywhere in the app without having to have a whole redirect to /messages

@spectrum-bot
Copy link

spectrum-bot bot commented Mar 1, 2019

Warnings
⚠️

These modified files do not have Flow enabled:

  • src/views/titlebar/index.js

Generated by 🚫 dangerJS

@brianlovin
Copy link
Contributor Author

Doing a prod cut this morning, going to admin merge. Open to any follow-on feedback.

@brianlovin brianlovin merged commit f44698d into alpha Mar 2, 2019
@brianlovin brianlovin deleted the fix-mobile-dm-compose branch March 2, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: messaging a user from the profile view doesn't open the DM composer

2 participants