This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
Closes #4743
This fixes a nasty bug where DMing someone from their user profile on mobile would not actually take you to the new message composer screen. The root cause of this issue was that we added a
/messages/newroute intosrc/routes.js- in the DM view, we were checking formatch.params.threadIdand seeing ifthreadId === 'new'to determine if we should show the composer or not. But since/messages/newdoes not pass anymatch.params, this was failing.I've cleaned up that logic by removing the unneeded route entirely. @mxstbr a future iteration here - which isn't high priority right now - is to support
/messages/newas a modal route so that you can initiate a DM from anywhere in the app without having to have a whole redirect to/messages