-
Notifications
You must be signed in to change notification settings - Fork 23
Feat: Add section covering BOBA integration #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mkdocs.yml
Outdated
| - Boba Networks: | ||
| - Price Feeds: chains/boba/price-feeds.md | ||
| - Addresses: chains/boba/addresses.md | ||
| - Conflux Networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use project names here, so "Conflux Network" is the right name.
mkdocs.yml
Outdated
| - Recap: tutorials/bitcoin-price-feed/recap.md | ||
| - Other chains: | ||
| - Conflux Network: | ||
| - Boba Networks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use project names here, so "Boba" is the right name.
| You can find a complete list of supported networks in [here][addresses]. | ||
|
|
||
| !!! tip "Tip: deploying to EVM-compatible chains others than Ethereum" | ||
| Just set the `WITNET_EVM_REALM` environment variable to any of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking that we can actually read the realm from the --network <realm>.<chain> argument to make things even simpler 🤔
For this suggestion to work the same in all networks, we just need to make sure that users also provide that flag when compiling, e.g.: yarn compile --network boba.rinkeby. If they don't provide the flag, truffle will obviously be using the default compiler with the Ethereum settings.
I made this change locally and I can confirm it works. It's basically the same but using a flag instead of an environment variable (which depending on the OS and the tech-savviness of the user, it may pose UX challenges)
Of course using an environment variable has the convenience for, imagine, Boba devs, to always have their projects default to Boba realm.
With all of this in mind, maybe the best thing we can do is from_flag || from_env || default. What do you think?
| | Contract | BOBA.Rinkeby | BOBA.Mainnet | | ||
| | :------- | :----------- | :----------- | | ||
| | **WitnetRequestBoard** | [`0xA2F4f5290F9cfD3a17Cfa82f2a2fD3E5c05d1442`](https://blockexplorer.rinkeby.boba.network/address/0xA2F4f5290F9cfD3a17Cfa82f2a2fD3E5c05d1442/contracts) | Stay tuned! | ||
| | **WitnetParserLib** | [`0xdF4Df677F645Fe603a883Ad3f2Db03EDFDd75F5C`](https://blockexplorer.rinkeby.boba.network/address/0xdF4Df677F645Fe603a883Ad3f2Db03EDFDd75F5C/contracts) | Stay tuned! | ||
| | **OmgBtcPriceFeed** | [`0x78C2dEb1A416508fB4B20A000cfD9d9673371e00`](https://blockexplorer.rinkeby.boba.network/address/0x78C2dEb1A416508fB4B20A000cfD9d9673371e00/contracts) | Stay tuned! | ||
| | **OmgEthPriceFeed** | [`0x6be8bb17C07453d217cd1BADBa3E55A627DcdD2A`](https://blockexplorer.rinkeby.boba.network/address/0x6be8bb17C07453d217cd1BADBa3E55A627DcdD2A/contracts) | Stay tuned! | ||
| | **OmgUsdtPriceFeed** | [`0x758C5adBFC25E260C07535933874e98583A14d41`](https://blockexplorer.rinkeby.boba.network/address/0x758C5adBFC25E260C07535933874e98583A14d41/contracts) | Stay tuned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do these tables look like once rendered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean inside mkdocs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Closes #93.