treecontrol attributes to control ordering (order-by & reverse-order) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoavaa
added a commit
that referenced
this pull request
Apr 3, 2014
treecontrol attributes to control ordering (order-by & reverse-order)
gempesaw
added a commit
to honeydew-sc/honeydew-ng
that referenced
this pull request
Dec 20, 2014
Pass-through support for the orderBy filter was added to the main project in wix-incubator/angular-tree-control#15. However, this was breaking the sorting for our app where we sort on our own beforehand in the backend, and manually sort after adding new branches and leaves to the tree. It seems like having an empty orderBy expression in the template was leading to issues since each one of our nodes are actually objects, so a naive sort implementation wouldn't be able to sort it properly. This is just a temporary fix while we attempt to address the issue upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes allow a developer to control the ordering of sibling nodes on the front-end without requiring the tree data to be changed.