Skip to content

Handle logging in async function #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2020
Merged

Handle logging in async function #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f853298
handle log in async
rynop Apr 16, 2020
afece1c
explicit set
rynop Apr 20, 2020
9572cab
test case
rynop Apr 20, 2020
bdb2bc1
why do I have to commit to run local test?
rynop Apr 20, 2020
92127be
handle falsey userCallsite for line and col number
rynop Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions detox/src/utils/customConsoleLogger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ function getStackDump() {

function getOrigin() {
const userCallsite = callsites()[USER_STACK_FRAME_INDEX];
const filename = path.relative(process.cwd(), userCallsite.getFileName());
return `at ${filename}:${userCallsite.getLineNumber() || '?'}:${userCallsite.getColumnNumber() || '?'}`;
const callsiteFilename = userCallsite && userCallsite.getFileName();
const callsiteLine = userCallsite && userCallsite.getLineNumber();
const callsiteCol = userCallsite && userCallsite.getColumnNumber();
const filename = callsiteFilename ? path.relative(process.cwd(), callsiteFilename) : '<unknown>';
return `at ${filename}:${callsiteLine || '?'}:${callsiteCol || '?'}`;
}

function override(consoleLevel, bunyanFn) {
Expand Down
10 changes: 10 additions & 0 deletions detox/src/utils/customConsoleLogger.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,16 @@ describe('customConsoleLogger', () => {
expect(bunyanLogger.mock).toHaveBeenCalledWith(ignored(), expect.stringContaining(expectedOrigin), ignored(), ignored());
});

it('should handle unknown file in origin', () => {
mockCallsites({file: undefined, line: undefined, col: undefined});

const logger = require('./customConsoleLogger');
logger.override('__log', bunyanLogger.mock);
console.__log('');

expect(bunyanLogger.mock).toHaveBeenCalledWith(ignored(), expect.stringContaining('<unknown>:?:?'), ignored(), ignored());
});

it('should handle missing file line/column in origin', () => {
mockCallsites({file: 'mockfilename', line: undefined, col: undefined});

Expand Down