Add Navigation.dismissAllOverlays api #6812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #4346
guyca
requested changes
Dec 3, 2020
...roid/app/src/main/java/com/reactnativenavigation/viewcontrollers/overlay/OverlayManager.java
Outdated
Show resolved
Hide resolved
danilobuerger
previously approved these changes
Dec 3, 2020
Contributor
danilobuerger
left a comment
danilobuerger
left a comment
There was a problem hiding this comment.
iOS part looks good, @guyca please review the rest.
Collaborator
|
Amazing work @mateioprea 🔥 |
Contributor
Author
|
@guyca just added the docs. we should be good to go |
guyca
approved these changes
Dec 7, 2020
Contributor
|
:') thank you guys <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4346