Skip to content

iOS: waitForRender option is ignored in 8.x #8144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2025
Merged

iOS: waitForRender option is ignored in 8.x #8144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1272be0
iOS: waitForRender option is ignored in 8.x
markdevocht Nov 11, 2025
efda1c9
Merge branch 'master' into bugfix/8126-ios-waitforrender
markdevocht Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions lib/ios/RNNReactView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,17 @@ - (instancetype)initWithHost:(RCTHost *)host
- (void)surface:(__unused RCTSurface *)surface didChangeStage:(RCTSurfaceStage)stage {
RCTExecuteOnMainQueue(^{
[super surface:surface didChangeStage:stage];
[self reactViewReady];
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(contentDidAppear:)
name:RCTContentDidAppearNotification
object:nil];
});
}

- (void)contentDidAppear:(NSNotification *)notification {
[self reactViewReady];
}

#else

- (void)contentDidAppear:(NSNotification *)notification {
Expand All @@ -96,9 +104,9 @@ - (void)reactViewReady {
_reactViewReadyBlock();
_reactViewReadyBlock = nil;
}
#ifndef RCT_NEW_ARCH_ENABLED

[[NSNotificationCenter defaultCenter] removeObserver:self];
#endif

}

#pragma mark - RNNComponentProtocol
Expand Down