Skip to content

Conversation

@wiziple
Copy link
Owner

@wiziple wiziple commented Jul 9, 2019

#44

@angrypie
Copy link
Contributor

angrypie commented Jul 9, 2019

Do you need to check trailing slash in wrap-page.js in the same way?

@wiziple
Copy link
Owner Author

wiziple commented Jul 9, 2019

No, i don't think so. 😄

@wiziple wiziple self-assigned this Jul 9, 2019
@talensjr
Copy link
Contributor

talensjr commented Jul 24, 2019

Hi, I installed and use this version, it improved a lot with those fixes, but as @angrypie suggested, I think it would be necessary to check the trailing slash in the same way in the wrap-page.js as I used the plugin to remove trailing slashes, and if I (or any user) attempts to go to /onboard/ with a trailing slash, it would be redirected to a 404, it would be cool if both work, with and without trailing /.

Regards 😄

PS: I can do it if you want, but I think is very mach the same as the fix in link.js

@wiziple wiziple merged commit b5d3844 into master Jul 25, 2019
@wiziple wiziple deleted the versions/0.2.7 branch July 25, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants