Fail build when translation json file not found #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create test for success reading the files. create test for failure when file couldn't be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the file is not found, the plugin doesn't crash the build or logs the error, so there's no way for a developer to now that the issue is with the path provided to the json files.
I added the extra log
console.error('[gatsby-plugin-intl] error', error)to signal that the issue is being logged from this plugin, but maybe this is not necessary.In any case, throwing the error I think should be the default behavior. What do you think?
I also added some tests to validate this change, but the tests didn't seem to be working:
context: {}to themockobject.Let me know if you want me to restore the tests back to how they were before.