Rewrite globeCoordinate.GlobeCoordinate.equals #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #115this will allow us to remove an other giant chunk of the formatting logic.Note that I intentionally changed this code in a way that no test needed adjustment. (And there are quite a lot of test cases.) The
/ 2division makes sense when you think of it this way: Let's say the first coordinate is given as 173°, and the second as 173.5°, both with a precision of 1°. This means the first is rendered as "173°", but the second as "174°". Because of this they must be considered unequal, even if the difference between the two is only 1/2 of the precision.Bug: T172916