Unify names of time precision constants#68
Conversation
There was a problem hiding this comment.
Are these not used anywhere? Also, is this change consistent with what we have in PHP?
And finally, is this really better? Sure, it's the same format, though is it how those things are normally written? I suspect not, which is supported by http://en.wiktionary.org/wiki/Gyr
+0
There was a problem hiding this comment.
Currently these JavaScript constants are not used anywhere. They were just introduced in the unreleased 0.7.0.
PHP constants are named different, see https://gerrit.wikimedia.org/r/#/c/194306/. This is the main reason why I touch this: 1. PHP constants use lower (!) case characters. 2. PHP and JavaScript constants are named differently.
If there is a better naming scheme, I'm open for suggestions.
thiemowmde
force-pushed
the
precisionConsts
branch
from
7461905 to
4befc83
Compare
This requires wmde/Time#42 and a new release of DataValues Time. Same patch in JavaScript: wmde/DataValuesJavaScript#68 Bug: T96685 Bug: T99911 Change-Id: I9489af3950c65620e007d739ca2e161e1a0a81e6
Unify names of time precision constants
|
Don't forget to update the release notes. And perhaps the @SInCE tag for the SELF.PRECISIONS constant should be updated as well |
|
Done in #83, thanks. |
3 participants
Same patch in PHP: https://gerrit.wikimedia.org/r/#/c/194306/
Bug: T99911