Skip to content

Optional hour:minute, second and timezone in TimeValue#73

Merged
filbertkm merged 1 commit intomasterfrom
optionalTime
Jun 1, 2015
Merged

Optional hour:minute, second and timezone in TimeValue#73
filbertkm merged 1 commit intomasterfrom
optionalTime

Conversation

@thiemowmde
Copy link
Copy Markdown
Contributor

This restores the behavior of the old regex in https://github.com/wmde/DataValuesJavascript/blob/0.6.1/lib/time/time.Time.js#L259:

  • The trailing "Z" is optional.
  • Second is optional.
  • Hour:minute is optional.
  • Hour, minute and second can have any number of digits, similar to day and month.

Note that actual validation should not be done here but server-side instead. Therefor it's ok to have a very relaxed regex here.

Bug: T89243

@thiemowmde thiemowmde added this to the 0.7 milestone Mar 4, 2015
@thiemowmde thiemowmde changed the title [WIP] Optional hour:minute, second and timezone in TimeValue Optional hour:minute, second and timezone in TimeValue Mar 16, 2015
@thiemowmde
Copy link
Copy Markdown
Contributor Author

I added tests. I would love to have this merged before making a new release because this restores behavior that got removed in #61. @adrianheine?

@thiemowmde thiemowmde force-pushed the optionalTime branch 2 times, most recently from 6ca7c42 to c4e6ca5 Compare March 16, 2015 10:37
@thiemowmde
Copy link
Copy Markdown
Contributor Author

I refuse to make the code worse and less readable because of an obtrusive tool with rules that neither indicate errors nor increase readability.

PS: Feel free to add a commit and revert my change in .jshintrc if you care.

filbertkm added a commit that referenced this pull request Jun 1, 2015
Optional hour:minute, second and timezone in TimeValue
@filbertkm filbertkm merged commit 4837385 into master Jun 1, 2015
@filbertkm filbertkm deleted the optionalTime branch June 1, 2015 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants