Optional hour:minute, second and timezone in TimeValue#73
Merged
Conversation
163d86b to
619888b
Compare
Contributor
Author
|
I added tests. I would love to have this merged before making a new release because this restores behavior that got removed in #61. @adrianheine? |
6ca7c42 to
c4e6ca5
Compare
Contributor
Author
|
I refuse to make the code worse and less readable because of an obtrusive tool with rules that neither indicate errors nor increase readability. PS: Feel free to add a commit and revert my change in .jshintrc if you care. |
c4e6ca5 to
89af5e5
Compare
filbertkm
added a commit
that referenced
this pull request
Jun 1, 2015
Optional hour:minute, second and timezone in TimeValue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the behavior of the old regex in https://github.com/wmde/DataValuesJavascript/blob/0.6.1/lib/time/time.Time.js#L259:
Note that actual validation should not be done here but server-side instead. Therefor it's ok to have a very relaxed regex here.
Bug: T89243