Fix comments on laika #1663
Merged
Fix comments on laika #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Buefy check boxes did not send the right boolean values for the PHP code, which also did not check for all possible "boolean"-ish values. Introduced a hidden field with the default value for "anonymous" which is sent when the checkbox is NOT checked (inverting the boolean).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Buefy check boxes did not send the right boolean values for the
PHP code, which also did not check for all possible "boolean"-ish
values.
Introduced a hidden field with the default value for "anonymous" which
is sent when the checkbox is NOT checked (inverting the boolean).
This fixes https://phabricator.wikimedia.org/T238339