Skip to content

Fix calendar switch to Julian (Bug 65847).#109

Merged
tobijat merged 4 commits intomasterfrom
fix-calendar-switch
Sep 2, 2014
Merged

Fix calendar switch to Julian (Bug 65847).#109
tobijat merged 4 commits intomasterfrom
fix-calendar-switch

Conversation

@ghost
Copy link

@ghost ghost commented Aug 27, 2014

No description provided.

@filbertkm
Copy link
Member

this allows me to change the calendar but not save it.

@ghost
Copy link
Author

ghost commented Aug 27, 2014

Is it supposed to? That doesn't seem to be related to what broke the "change to Julian" button.

@ghost
Copy link
Author

ghost commented Sep 1, 2014

@filbertkm I investigated the issue with @snaterlicious and found the bug in DataValuesJavascript which already got fixed here wmde/DataValuesJavaScript@c4fb292

@filbertkm
Copy link
Member

why is Wikibase (or ValueView) not using DataValuesJavascript 0.6.0 that has the fix? then it would be easier to verify the issue is fixed together with this change.

@tobijat
Copy link
Contributor

tobijat commented Sep 1, 2014

@filbertkm because it was released 8 minutes ago

@snaterlicious
Copy link
Contributor

Since I was investigating the code, I added some general sanitazion.
Still, there appears to be an issue. Steps to reproduce:

  1. Switch to other calender by clicking the calendar hint.
  2. Cancel editing.
  3. Start editing and try to switch the calendar by clicking the calendar hint.
    Observation: The actual listrotator (advanced adjustments) changes its value but the actual data value is not changed (no parsing is triggered, the preview and the calendar hint are not updated).
    There may be a conceptual problem with the lines affected by the actual fix - I added a FIXME there. The reason may be that the ExpertExtender.Listorator object is not affected by the functionality of those lines. Probably, the functionality needs to be implemented in the ExpertExtender.Listorator instead of circumventing it by directly manipulating the listrotator jQuery widget.

@tobijat
Copy link
Contributor

tobijat commented Sep 2, 2014

The bug @snaterlicious describes is more general and is not related to this fix. I created a separate ticket for it: https://bugzilla.wikimedia.org/show_bug.cgi?id=70294

tobijat added a commit that referenced this pull request Sep 2, 2014
Fix calendar switch to Julian (Bug 65847).
@tobijat tobijat merged commit 4695925 into master Sep 2, 2014
@tobijat tobijat deleted the fix-calendar-switch branch September 2, 2014 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants