Implement UnDeserializableValue expert#171
Conversation
|
in wikibase, looks like https://phabricator.wikimedia.org/F167582 |
There was a problem hiding this comment.
I wonder why this message is hardcoded? Is this a work in progress?
There was a problem hiding this comment.
i18n messages get merged in and applied if mediawiki is available. i think this is just a default or something.
anyway, i have changed the code to reuse the existing formatted value (error message) which means we don't need the same message twice (once in wikibase, and once here which then never gets translated because this component is not in gerrit)
filbertkm
force-pushed
the
undeserializable-expert
branch
3 times, most recently
from
bd653ff to
6de797b
Compare
There was a problem hiding this comment.
The addition of a feature can be done in a 0.0.x step, as long as the component is in the 0.x range.
thiemowmde
force-pushed
the
undeserializable-expert
branch
from
6de797b to
9f72fcc
Compare
|
@filbertkm I decreased the version to 0.14.4. I would merge if this is ok for you. |
|
If you wanna make a 0.15 release anyways (#172) why not just put this also in that release? |
|
Depends on what gets merged and released first. This way we simply have more options. |
Implement UnDeserializableValue expert
4 participants
based on the UnsupportedValue expert, will display the error and allow a user to remove the value.
not super fancy. It would be nicer to display some details of the value or make more attempt to try to parse it or such again. but don't want to make things too "smart" at this point.
this works okay and provided improvement over the current handling.
Bug: T92975
Bug: T101231