Skip to content

Add monolingualtext expert#59

Merged
thiemowmde merged 4 commits intomasterfrom
mono
Jun 25, 2014
Merged

Add monolingualtext expert#59
thiemowmde merged 4 commits intomasterfrom
mono

Conversation

@adrianheine
Copy link
Contributor

Missing README update and version bump.

@tobijat
Copy link
Contributor

tobijat commented Jun 6, 2014

This still has some layout glitches. See screenshot.
clipboard01

@tobijat
Copy link
Contributor

tobijat commented Jun 6, 2014

Also it seems to influence the entity selector. See screenshot.
clipboard02

@JeroenDeDauw
Copy link
Member

Oh no. @tobijat is using the image attach feature in a useful way. Need to counter!

nyan_data

@adrianheine
Copy link
Contributor Author

I wasn't able to reproduce that right now, but with jQuery UI 1.9 everything's different :)

@tobijat
Copy link
Contributor

tobijat commented Jun 11, 2014

Ok, just figured out both layout issues mentioned above are only occuring when debug-mode is off. With debug=true it works for me.

@adrianheine
Copy link
Contributor Author

Can reproduce in debug off. Damn.

@adrianheine
Copy link
Contributor Author

Wow. It was a simple CSS syntax error in this commit. I just spent 4 hours crawling through ResourceLoader in order for that to find. Anyway, works for me now.

@tobijat
Copy link
Contributor

tobijat commented Jun 16, 2014

One issue I have is: if I clean the the input-field of the language-selector, it jumps back to the previous selected language after a short moment. This makes it impossible for me to change the language.

@adrianheine
Copy link
Contributor Author

Should work now.

@thiemowmde
Copy link
Contributor

+1! Played around with the UI and like it very much so far. :-) Simple, easy to understand.

Things on my personal wish-list (not necessary blockers for this pull request, actually most of this may be upstream issues in other code):

  1. [This is a bug in the PHP parser.] When I just type something and hit return the value is just saved (which is good in my opinion) but the default language was not visible in the language selector. To make this consistent it should show the default language and not be empty.
  2. [This is a bug in the PHP parser.] It seems it always defaults to English. It should default to my UI language. (This is the only blocker in my opinion, the others are not.)
  3. [This is a bug in all experts.] When I type a space the language selection is shown but I can not save. To make this consistent the code that makes the language selection visible should use a trimmed value.
  4. [This is a bug in all experts.] When I click the language field and hold the mouse button for a second the language popup closes. This is a bit strange. The field should have the focus the moment I clicked it. Why does it close half a second later? Seems there is something bound to the release handler that probably shouldn't.
  5. Is it possible to have the label and the input field in one row?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it does use ULS, doesn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but the backend uses \Languages.

@thiemowmde
Copy link
Contributor

Did you missed my #59 (comment)?

@adrianheine
Copy link
Contributor Author

1.: / 2.: I think it's wrong to have a default language, and I think we should change DataValues to allow and default to no language set.
3.: I can save with a space as language.
4.: Can't reproduce, closes for me instantly on mousedown in Chromium.
5.: If that's what @lydiapintscher and @snaterlicious want …

@adrianheine
Copy link
Contributor Author

Missing:

  • @lydiapintscher: Clarify default language (no language? default wiki language? user language?)
  • @adrianlang: Make ULS dependency optional, make sure it falls back to simple input box without ULS
  • README update, version bump

@lydiapintscher
Copy link
Member

Hmmmm default language... It should definitely not be the default wiki language. That leaves us no language or the user language. We should try to minimize the times people actually have to change the default. Given that no language selected means people will always have to change it that is not good. Using the user's language gives us at least some cases where they can use what is already selected for them (even if that might not be many).

@thiemowmde
Copy link
Contributor

@adrianlang @lydiapintscher There currently is a default language, at least that's how it looks like from a users perspective. It's just implemented inconsistently. 3./4.: Please poke me if you are at the office. Seems there is a bit of misunderstanding.

@adrianheine
Copy link
Contributor Author

I think we should maximize the times people have to change the language, because it's not some obscure setting, it's an integral part of the value, and people have to be aware of it. Using the user's UI language as default on the other hand supports the misunderstanding that this is some value to be translated. Also, I think ›no language‹ is a valid value here, since most real-world strings have a language, but not every user might now which language it is.

@lydiapintscher
Copy link
Member

Discussed this quickly in-person. Result: Let's start with no language selected by default and let's not allow adding statements without an unknown language or no language for now.

@adrianheine
Copy link
Contributor Author

I think default language is something which has to be done in the backend exclusively. So, from my point of view, this pull request only lacks README and version bump. @thiemowmde, what do you think?

thiemowmde added a commit that referenced this pull request Jun 25, 2014
Add monolingualtext expert
@thiemowmde thiemowmde merged commit 539a608 into master Jun 25, 2014
@thiemowmde thiemowmde deleted the mono branch June 25, 2014 09:27
@thiemowmde thiemowmde added this to the 0.6.3 milestone Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants