Conversation
|
Oh no. @tobijat is using the image attach feature in a useful way. Need to counter! |
|
I wasn't able to reproduce that right now, but with jQuery UI 1.9 everything's different :) |
|
Ok, just figured out both layout issues mentioned above are only occuring when debug-mode is off. With debug=true it works for me. |
|
Can reproduce in debug off. Damn. |
|
Wow. It was a simple CSS syntax error in this commit. I just spent 4 hours crawling through ResourceLoader in order for that to find. Anyway, works for me now. |
|
One issue I have is: if I clean the the input-field of the language-selector, it jumps back to the previous selected language after a short moment. This makes it impossible for me to change the language. |
|
Should work now. |
|
+1! Played around with the UI and like it very much so far. :-) Simple, easy to understand. Things on my personal wish-list (not necessary blockers for this pull request, actually most of this may be upstream issues in other code):
|
There was a problem hiding this comment.
But it does use ULS, doesn't it?
There was a problem hiding this comment.
Yes, but the backend uses \Languages.
|
Did you missed my #59 (comment)? |
|
1.: / 2.: I think it's wrong to have a default language, and I think we should change DataValues to allow and default to no language set. |
|
Missing:
|
|
Hmmmm default language... It should definitely not be the default wiki language. That leaves us no language or the user language. We should try to minimize the times people actually have to change the default. Given that no language selected means people will always have to change it that is not good. Using the user's language gives us at least some cases where they can use what is already selected for them (even if that might not be many). |
|
@adrianlang @lydiapintscher There currently is a default language, at least that's how it looks like from a users perspective. It's just implemented inconsistently. 3./4.: Please poke me if you are at the office. Seems there is a bit of misunderstanding. |
|
I think we should maximize the times people have to change the language, because it's not some obscure setting, it's an integral part of the value, and people have to be aware of it. Using the user's UI language as default on the other hand supports the misunderstanding that this is some value to be translated. Also, I think ›no language‹ is a valid value here, since most real-world strings have a language, but not every user might now which language it is. |
|
Discussed this quickly in-person. Result: Let's start with no language selected by default and let's not allow adding statements without an unknown language or no language for now. |
|
I think default language is something which has to be done in the backend exclusively. So, from my point of view, this pull request only lacks README and version bump. @thiemowmde, what do you think? |



Missing README update and version bump.