Add Assign Milestone Workflow #41
Conversation
mikejolley
left a comment
mikejolley
left a comment
There was a problem hiding this comment.
comment-this should add milestone
mikejolley
changed the title
|
➿ Code coverage
|
nerrad
left a comment
nerrad
left a comment
There was a problem hiding this comment.
Looks good to me, nothing really leapt out to me in the review other than the thought about what tag we might want to release this with. That can be handled on followup though, so let's see what approving this does :)
| pull-request-automation: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: woocommerce/automations@v1 |
There was a problem hiding this comment.
I wonder if we should release a @v2 as a result of implementing the new automation (that way if there are unintended issues with existing automations folks can rollback)?
This can be done in a followup if we end up doing that.
There was a problem hiding this comment.
Yup I'm fine with that. This shouldn't affect existing workflows because you'd need to call assign-milestone by name in your workflow file?
There was a problem hiding this comment.
Oh true, I guess there's not any changes to existing tasks (or shared code across tasks) so it's safe to release under the existing version. We could probably reserve version bumps for when there's potentially task breaking changes.
Are you okay with doing a release or want me to take care of it? If you take care of it, this repo uses the release PR automation (similar to process we follow for blocks repo) except the checklist is much smaller. It's currently mostly manual as it's mostly just creating the correct tags etc. The release PR checklist should have all the steps needed.
|
Looks like it worked! |
Adds a new action to assign the next milestone to an approved PR. To test, approve this PR :)
This is for woocommerce/woocommerce-blocks#4223