Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Payment Method Improvements] Create the "Record transaction details in order note" section #11569

Merged
merged 36 commits into from
May 28, 2024

Conversation

backwardstruck
Copy link
Contributor

@backwardstruck backwardstruck commented May 22, 2024

Adresses: #11525

Also contains changes from this PR which have already been reviewed:

#11570

Follow up items from that PR are in this ticket at TODOs:
#11583

Description

Add the toggle for "Record transaction details in order note" in the Change Due Calculator screen.

Also addresses some feedback from the previous PR that @JorgeMucientes provided me with:

Testing instructions

  1. Enable OTHER_PAYMENT_METHODS
  2. Go to an order that needs to be paid
  3. Select "Cash"
  4. Make sure toolbar back button works

Expected: You should see the Change Due screen

No added functionality, that will be added here. UI should look similar to iOS:

IMG_0447

These issues should be fixed:

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
FlavorJalapeno
Build TypeDebug
Commit484b8d7
Direct Downloadwoocommerce-prototype-build-pr11569-484b8d7.apk

@backwardstruck backwardstruck added type: enhancement A request for an enhancement. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels May 22, 2024
@backwardstruck backwardstruck added this to the 18.8 milestone May 22, 2024
@backwardstruck backwardstruck marked this pull request as ready for review May 22, 2024 19:19
@backwardstruck backwardstruck marked this pull request as draft May 23, 2024 18:02
@backwardstruck backwardstruck added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 23, 2024
Base automatically changed from 11525-change-due-calculator-ui-part-2 to trunk May 23, 2024 18:12
@ThomazFB ThomazFB assigned ThomazFB and unassigned ThomazFB May 24, 2024
@backwardstruck backwardstruck modified the milestones: 18.8, 18.9 May 24, 2024
@backwardstruck backwardstruck marked this pull request as ready for review May 24, 2024 18:54
@backwardstruck backwardstruck removed status: do not merge Dependent on another PR, ready for review but not ready for merge. labels May 24, 2024
…e-due-calculator-ui-part-4

# Conflicts:
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorFragment.kt
#	WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/changeduecalculator/ChangeDueCalculatorScreen.kt
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (d5d0a51) to head (484b8d7).

Files Patch % Lines
...hangeduecalculator/ChangeDueCalculatorViewModel.kt 60.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11569      +/-   ##
============================================
- Coverage     40.34%   40.34%   -0.01%     
+ Complexity     5200     5199       -1     
============================================
  Files          1087     1087              
  Lines         63247    63250       +3     
  Branches       8668     8669       +1     
============================================
- Hits          25520    25519       -1     
- Misses        35432    35436       +4     
  Partials       2295     2295              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backwardstruck
Copy link
Contributor Author

@ThomazFB this should be ready for review now. I've tried to follow the existing UI and patterns in the app but open to suggestions.

Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as described! Also, nice work with the unit test coverage! Just left some suggestions over the ViewModel usage, but nothing critical.

@backwardstruck backwardstruck merged commit 66933dd into trunk May 28, 2024
14 checks passed
@backwardstruck backwardstruck deleted the 11525-change-due-calculator-ui-part-3 branch May 28, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: enhancement A request for an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants