[Payment Method Improvements] Tapping Order Complete button should be equivalent tapping Mark as Paid

[backwardstruck]

Closes: #11583

Description

This PR is to update the change due correctly based on the user input for how much cash was given.

• I added the unit-tests-exemption label as this PR is dependent on others and will likely change. Updating the test is ticketed here:
  [Payment] Testing: Add implementation so order details load successfully, emits success state and all tests pass #11542

Testing instructions

1. Enable OTHER_PAYMENT_METHODS
2. Go to an order that needs to be paid
3. Select "Cash"
4. Enter a cash value (try again without entering anything)
5. Tap "Mark Order As Complete" button

Expected:

• Screen should close and return to the order screen (closing the payment method screen as well)
• The order should be marked as paid/completed
• Amount paid should be accurate on the order

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[dangermattic]

	1 Warning
⚠️	Class Success is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Flavor	Jalapeno
	Build Type	Debug
	Commit	d5747fb
	Direct Download	woocommerce-prototype-build-pr11587-d5747fb.apk

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 40.34%. Comparing base (484b8d7) to head (d5747fb).
Report is 49 commits behind head on trunk.

Files	Patch %	Lines
...hangeduecalculator/ChangeDueCalculatorViewModel.kt	58.33%	5 Missing ⚠️
...ts/methodselection/SelectPaymentMethodViewModel.kt	0.00%	4 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #11587      +/-   ##
============================================
- Coverage     40.34%   40.34%   -0.01%     
  Complexity     5199     5199              
============================================
  Files          1087     1087              
  Lines         63250    63265      +15     
  Branches       8669     8671       +2     
============================================
+ Hits          25519    25524       +5     
- Misses        35436    35445       +9     
- Partials       2295     2296       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kidinov]

Shell, you go back and bring result with "is order paid = true/false" instead of going forward and passing "true" always? Check the setupResultHandlers method in SelectPaymentMethodFragment - I believe they do pretty much the same as what you need in order to deliver the result back

[backwardstruck]

Thanks. I'll do it that way instead as you suggested. Added to this ticket for my draft PR:
#11585

[kidinov]

Overall some things I noted (sorry if this is already fixed in the following PRs and I repeat myself):

• I think there is something wrong with margins/paddings on the UI (vertically it should be either 8/16 or 32 in some cases, and horizontally sheel we have 16 margins from the borders of the screen)? The button is not aligned with input field on the right. The input field has large margin on the left than on the right
• The screen is not scrollable so not possible to click the button when the keyboard is visible
• In the PR description, it says

Switched to WCOutlinedTypedTextField like it's used in OrderCreateEditProductDiscountScreen and changed the button to use WCColoredButton as suggested here by @kidinov

But I still see WCMaterialOutlinedCurrencyEditTextView is being used

• We'd need to fix the layout for the text that displays the change

• Just an advice for the future PR - better to make the not toggle "clickable" including the text itself and with some padding so it's easier to tap on

[kidinov]

There are a few notes I left which I think worth attention, but you can fix them in the open PR so not blocking this one

[backwardstruck]

Overall some things I noted (sorry if this is already fixed in the following PRs and I repeat myself):

• I think there is something wrong with margins/paddings on the UI (vertically it should be either 8/16 or 32 in some cases, and horizontally sheel we have 16 margins from the borders of the screen)? The button is not aligned with input field on the right. The input field has large margin on the left than on the right
• The screen is not scrollable so not possible to click the button when the keyboard is visible
• In the PR description, it says

Switched to WCOutlinedTypedTextField like it's used in OrderCreateEditProductDiscountScreen and changed the button to use WCColoredButton as suggested here by @kidinov

But I still see WCMaterialOutlinedCurrencyEditTextView is being used

• We'd need to fix the layout for the text that displays the change

* Just an advice for the future PR - better to make the not toggle "clickable" including the text itself and with some padding so it's easier to tap on

Sorry for the confusion @kidinov my PR description was innaccurate. Those changes are in this PR:

https://github.com/woocommerce/woocommerce-android/pull/11593/commits

I will update the margin and padding there as well.