Skip to content

Conversation

@chihsuan
Copy link
Member

@chihsuan chihsuan commented Jun 13, 2022

All Submissions:

Changes proposed in this Pull Request:

pbIJXs-219-p2#comment-4084

Fixes the spotlight location at the product tour step2.

Before:

Screen Shot 2022-06-13 at 11 18 49

After:

Screen Shot 2022-06-13 at 11 14 46

How to test the changes in this Pull Request:

  1. Install and activate WCA Test Helper
  2. Go to Tools > WCA Test Helper > Features
  3. Enable experimental-product-tour
  4. Go to Tools > WCA Test Helper > Experiments
  5. Add woocommerce_products_tour to treatment
  6. Go to WooCommerce > Home
  7. Click on "Add My Products" > Start with a template
  8. Select physical products and click "Go"
  9. Click Next button
  10. Observe the spotlight feature as per screenshot

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you created a changelog file for each project being changed, ie pnpm changelog add --filter=<project>?

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@chihsuan chihsuan marked this pull request as ready for review June 13, 2022 03:20
@github-actions github-actions bot added focus: react admin plugin: woocommerce Issues related to the WooCommerce Core plugin. labels Jun 13, 2022
@chihsuan chihsuan self-assigned this Jun 13, 2022
@chihsuan chihsuan requested a review from a team June 13, 2022 03:22
@botwoo
Copy link
Collaborator

botwoo commented Jun 13, 2022

📊 Test reports for this pull request have been published and are accessible through the following links:

Latest commit referenced in the reports: Fix product tour spotlight location 5c3f4ad
This comment will automatically be updated with the latest referenced commit when you push new changes to this pull request.


Visit the WooCommerce Test Reports homepage to view all published reports. See the FAQs page if you're having problems accessing them.

Copy link
Contributor

@moon0326 moon0326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well 👍 🚀

@chihsuan chihsuan merged commit 8fb9664 into trunk Jun 14, 2022
@chihsuan chihsuan deleted the fix/product-tour-spotlight-location branch June 14, 2022 02:22
@github-actions github-actions bot added this to the 6.7.0 milestone Jun 14, 2022
@github-actions
Copy link
Contributor

Hi @chihsuan, thanks for merging this pull request. Please take a look at these follow-up tasks you may need to perform:

  • Add the release: add testing instructions label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants