Send eMail notification to a configurable mail address in case of git Exceptions #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- plugin.info.txt:
- added myself to the list of authors
- updated date to 19-Mar-2021
- editcommit.php:
- pass plugin instance to GitRepo cTor
- added error notification helper methods
- catch Exceptions from underlying GitRepo or Git methods
to hide errors from end user rahter than sending error message by eMail
- Git.php:
- Git:
- added plugin instance to methods as paramater
- GitRepo:
- added plugin instance to cTor as parameter
- default.php, metadata.php, settings.php:
- added config 'emailAddressOnError'
- added config 'notifyByMailOnSuccess'
- lang/en:
- added localizations for error messages
- added eMail templates for mail notifocations
Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
- German translations added Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
- Git.php: - improved error handling for more consistent and obvious Exception throwing - lang/en/settings.php, lang/de/settings.php: - improved settings description Signed-off-by: Markus Hoffrogge <mhoffrogge@gmail.com>
|
thanks @mhoffrog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements Issue#53.
Fixes #53