[1 -2단계 - Tomcat 구현하기] 카피(김상혁) 미션 제출합니다 #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yechop
approved these changes
Sep 9, 2024
yechop
left a comment
yechop
left a comment
There was a problem hiding this comment.
전체적으로 잘 해주셨습니다 👍
수정 필요한 부분은 다음단계 진행하면서 고쳐주세요
404나 500 같은 페이지도 띄워주시면 좋을것 같습니다.
Http11Processor 리팩토링 기대할게요!
| String account = requestBody.split("&")[0].split("=")[1]; | ||
| String email = requestBody.split("&")[1].split("=")[1]; | ||
| String password = requestBody.split("&")[2].split("=")[1]; | ||
| InMemoryUserRepository.save(new User(account, email, password)); |
There was a problem hiding this comment.
User 생성 파라미터 순서가 틀려 회원가입이 정상적으로 작동하고 있지 않습니다.
| httpResponse = HttpResponse.of(version, 200, "text/html", responseBody); | ||
| httpResponse.addHeader("Location", "/index.html"); | ||
| httpResponse.addHeader("Set-Cookie", "JSESSIONID=" + jSessionId); | ||
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
반갑습니다 잉크!
HttpRequest와 HttpResponse 정도만 분리해보았습니다!
잘 부탁드립니다!
학습테스트는 추가로 커밋 올릴게요!