Skip to content

Add explanatory comments to the conditional HTMLParser imports #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Add explanatory comments to the conditional HTMLParser imports #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...tecTests/Converters/AttributesToStringAttributes/BoldElementAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import XCTest
@testable import Aztec
// This test exercises sources from the Aztec target, but also uses internal APIs from HTMLParser.
//
// The HTMLParser target exists only when building for Swift package manager.
// Otherwise, such as when building via CocoaPods, its sources are part of Aztec.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions ...cTests/Converters/AttributesToStringAttributes/ItalicElementAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
@testable import Aztec
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions ...sts/Converters/AttributesToStringAttributes/UnderlineElementAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
@testable import Aztec
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions ...ztecTests/Converters/StringAttributesToAttributes/BoldStringAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
@testable import Aztec
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions ...ecTests/Converters/StringAttributesToAttributes/ItalicStringAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
@testable import Aztec
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions Tests/AztecTests/Importer/InAttributeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
import libxml2
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/AztecTests/Importer/InNodeConverterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
import libxml2
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/AztecTests/NSAttributedString/Conversions/AttributedStringSerializerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import XCTest
@testable import Aztec
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#endif
Expand Down
1 change: 1 addition & 0 deletions Tests/HTMLParserTests/HTML/Conversions/CSSParserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import XCTest
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/HTMLParserTests/HTML/Conversions/DefaultHTMLSerializerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import XCTest
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/HTMLParserTests/HTML/Conversions/HTMLParserTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import XCTest
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/HTMLParserTests/HTML/Nodes/ElementNodeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import XCTest
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down
1 change: 1 addition & 0 deletions Tests/HTMLParserTests/HTML/Nodes/TextNodeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import XCTest
// See comment in BoldElementToAttributeConverterTests.swift to understand the conditional import below.
#if SWIFT_PACKAGE
@testable import HTMLParser
#else
Expand Down