Add infrastructure for injecting media pickers #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
approved these changes
Oct 24, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Code looks sound to me. I did not perform any testing at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes CMM-862: Add a trailing bar button with more options.
Why?
We need a way to use all media picker sources available in the app: Files, Free GIFs and Images, Apple Intelligence, and more.
How?
The app provides the implementation for the media pickers. This PR adds a protocol for the app to inject the available pickers.
Note: I added CMM-890 to refactor the existing
didRequestMediaFromSiteMediaLibraryby implementing is aMediaPickerActionwith a predefined ID.Testing Instructions
There is currently nothing to test. You can see how it looks in the
BlockInserterViewSwiftUI protocol. It will be available for testing once we build GBK and integrate the updated version in the app.Screenshots or screencast