This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Version 1.3.3 with fixed warning #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jkmassel
approved these changes
Apr 15, 2019
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
This PR is doing a lot:
- CocoaPods upgrade
- CircleCI Config update
- Pod release
- Fixes the nullability issue
It's still short and sweet, so if you're good with lots going on in this one I am too – just figured I'd bring it up :)
Contributor
Author
|
Thanks, Jeremy. Yea, I think it's fine to keep these together since the changes are all simple. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor change to fix a nullability warning in
WPMediaPickerViewController.h. Doing this so we have one less warning in wordpress-mobile/WordPress-iOS#11381.