Skip to content

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Apr 14, 2021

Fixes #14438

Description

The original my_site_item_block.xml structure worked as expected in LTR languages and there is no structural reason to break in RTL. Thus the observed UI bug is most probably due to a ConstraintLayout bug (e.g.).
Note that we are using version 1.1.3 of ContraintLayout. I tested with 2.0.4(stable) and 2.1.0-beta1 and the issue is still reproduced.
As a workaround the layout was transformed to RelativeLayout.

A fix using ConstraintLayout was cherrypicked from @planarvoid's solution 4a51f62

To test:

  1. Set the Interface to an RTL (e.g. Hebrew or Arabic) language (Avatar>App Settings> Interface Language)
  2. Browse to My Site screen
  3. Verify that the options list is rendered correctly
Hebrew Before Hebrew with the Fix
device-2021-04-14-151741 device-2021-04-14-151602
Arabic English
device-2021-04-14-151645 device-2021-04-14-151513

Regression Notes

  1. Potential unintended areas of impact
    None identified

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis self-assigned this Apr 14, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 14, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 14, 2021

You can test the changes on this Pull Request by downloading the APK here.

@antonis antonis marked this pull request as ready for review April 14, 2021 12:36
@antonis antonis requested review from mkevins and planarvoid April 14, 2021 12:37
@antonis antonis marked this pull request as draft April 14, 2021 13:01
@antonis antonis force-pushed the issue/14438-rtlAlignement branch from 99b562b to b49c2ee Compare April 14, 2021 14:30
@antonis antonis marked this pull request as ready for review April 14, 2021 14:39
@antonis antonis added this to the 17.2 milestone Apr 14, 2021
@antonis antonis requested a review from chipsnyder April 15, 2021 17:08
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described and LGTM! 🚢

@antonis antonis merged commit d119cc0 into develop Apr 16, 2021
@antonis antonis deleted the issue/14438-rtlAlignement branch April 16, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

My Site navigations labels misaligned in RTL languages

2 participants