Skip to content

Jetpack App: Pass magic link scheme to signup flow #16449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2022
Merged

Jetpack App: Pass magic link scheme to signup flow #16449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82e8a95
Point to login lib PR commit
ashiagr Apr 30, 2022
3d98f59
Send magic link scheme to signup magic link fragment
ashiagr Apr 30, 2022
0dc425e
Update release notes
ashiagr May 2, 2022
f98aa72
Update login lib version
ashiagr May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* [*] Block Editor: Latest Posts block: Add featured image settings [https://github.com/WordPress/gutenberg/pull/39257]
* [*] Block Editor: Prevent incorrect notices displaying when switching between HTML-Visual mode quickly [https://github.com/WordPress/gutenberg/pull/40415]
* [*] Block Editor: Embed block: Fix inline preview cut-off when editing URL [https://github.com/WordPress/gutenberg/pull/35326]

* [*] Jetpack App: Fixes signup magic link URL [https://github.com/wordpress-mobile/WordPress-Android/pull/16449]
19.7
-----
* [*] [internal] Site creation: Adds a new screen asking the user the name of the site [https://github.com/wordpress-mobile/WordPress-Android/pull/16259]
Expand Down
4 changes: 3 additions & 1 deletion WordPress/src/main/java/org/wordpress/android/ui/accounts/LoginActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,10 @@ public void showMagicLinkSentScreen(String email, boolean allowPassword) {
@Override
public void showSignupMagicLink(String email) {
boolean isEmailClientAvailable = WPActivityUtils.isEmailClientAvailable(this);
AuthEmailPayloadScheme scheme = mViewModel.getMagicLinkScheme();
SignupMagicLinkFragment signupMagicLinkFragment = SignupMagicLinkFragment.newInstance(email, mIsJetpackConnect,
mJetpackConnectSource != null ? mJetpackConnectSource.toString() : null, isEmailClientAvailable);
mJetpackConnectSource != null ? mJetpackConnectSource.toString() : null, isEmailClientAvailable,
scheme);
slideInFragment(signupMagicLinkFragment, true, SignupMagicLinkFragment.TAG);
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ext {
wordPressUtilsVersion = '2.5.0'
wordPressLoginVersion = '0.13.0'
wordPressLoginVersion = 'trunk-3f0e3fc881b14836043d17c8654b52d57e4c1c12'
gutenbergMobileVersion = 'v1.75.0'
storiesVersion = '1.3.0'
aboutAutomatticVersion = '0.0.5'
Expand Down