feat: Improve app password required dialog #22196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove from abstract class to fix Jetpack Compose preview error: "render error."
Preview the actual UI code used by the app, rather than a copy of the dialog composition.
Communicate the dialog may be dismissed.
While Material's guidlines state to avoid unnecessary punctuation, all examples that have one more than one sentence use punctuation for all sentences.
Collaborator
Generated by 🚫 Danger |
|
Contributor
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22196-fe69565 | |
| Commit | fe69565 | |
| Direct Download | jetpack-prototype-build-pr22196-fe69565.apk |
Contributor
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22196-fe69565 | |
| Commit | fe69565 | |
| Direct Download | wordpress-prototype-build-pr22196-fe69565.apk |
dcalhoun
commented
Sep 10, 2025
Comment on lines
+71
to
+76
| val isLoading = viewModel.isLoading.collectAsState() | ||
| ApplicationPasswordDialog( | ||
| title = stringResource(getTitleResource()), | ||
| description = getDescriptionString(), | ||
| buttonText = getButtonTextResource(), | ||
| isLoading = isLoading.value, |
Member
Author
There was a problem hiding this comment.
Hoisted ViewModel to simplify Jetpack Compose component arguments and preview.
Comment on lines
-142
to
-145
| private fun ApplicationPasswordReauthenticateDialogPreviewContent() { | ||
| val isLoading = remember { mutableStateOf(false) } | ||
|
|
||
| AlertDialog( |
Member
Author
There was a problem hiding this comment.
Replaced explicit "preview" component with preview of the actual UI code used by the application.
| <string name="application_password_not_supported_error" a8c-src-lib="module:login">The provided site does not support Application Password authentication.</string> | ||
| <string name="application_password_invalid">Invalid Application Password</string> | ||
| <string name="application_password_invalid_description">Your application password no longer exists. Please sign in again to create a new application password </string> | ||
| <string name="application_password_invalid_description">Your application password no longer exists. Please sign in again to create a new application password.</string> |
Member
Author
There was a problem hiding this comment.
While Material guidelines suggest avoiding unnecessary punctuation, all examples with multiple sentences punctuate all sentences.
adalpari
approved these changes
Sep 11, 2025
Contributor
adalpari
left a comment
adalpari
left a comment
There was a problem hiding this comment.
Nice code improvement. Thanks!
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
Review each commit individually to simplify comprehending the changes.
Description
ApplicationPasswordReauthenticateDialogPreviewto fix JetpackCompose preview
ApplicationPasswordDialogfor Jetpack Compose to preview actual UIcomposition rather than duplicate
ApplicationPasswordDialogdismiss button to communicate ability todismiss the dialog
Testing instructions
Jetpack Compose preview images below showcase the updated visuals. Functional testing
can be performed by following the testing plan outlined in either of the
following: