CMM 628 add filesize to the media screen #22216

adalpari · 2025-09-17T10:50:18Z

Description

Added file size display functionality to the media details screens. The file size is now shown in a human-readable format (KB, MB, GB) in MediaSettingsActivity.

This new functionality has been added only to site logged in with Application Password. Will add it to WP sites in the next iteration.

Testing instructions

Log into a site WITHOUT Application Password
Go to Media -> Open any of the media file

Verify you don't see the filesize nor the app crashes

Log into a site with Application Password
Go to Media -> Open any of the media file

Verify you DO see the filesize

Screen.Recording.2025-09-17.at.12.43.07.mov

Copilot

Pull Request Overview

This PR adds file size display functionality to media details screens, showing file sizes in human-readable format (KB, MB, GB) for sites using Application Password authentication.

Adds file size field to MediaModel and database schema
Implements file size parsing from media API responses for all media types
Adds UI components to display formatted file size in MediaSettingsActivity

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
WellSqlConfig.kt	Database migration to add FILE_SIZE column to MediaModel table
MediaRSApiRestClient.kt	Parse and populate file size from API responses for all media types
MediaModel.java	Add file size field, getter/setter methods, and equality comparison
strings.xml	Add file size caption string resource
media_settings_activity.xml	Add UI layout for file size display with label and value
MediaSettingsActivity.java	Display formatted file size with conditional visibility logic

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-17T10:50:50Z

WordPress/src/main/java/org/wordpress/android/ui/media/MediaSettingsActivity.java

+            final String[] units = new String[] {
+                    getString(R.string.file_size_in_bytes),
+                    getString(R.string.file_size_in_kilobytes),
+                    getString(R.string.file_size_in_megabytes),
+                    getString(R.string.file_size_in_gigabytes),
+                    getString(R.string.file_size_in_terabytes)
+            };


The code references string resources (file_size_in_bytes, file_size_in_kilobytes, etc.) that are not defined in the strings.xml file. This will cause a compilation error or runtime crash.

These strings are defined in the strings file...

An aside: is it typical to use lowercase for kB, but uppercase for MB, GB, TB? The divergence seems odd to me.

The lowercase kB is even more odd now that I note that the server-provided values for WPCOM sites in #22220 return KB. I suggest we update the string from kB → KB. WDYT?

Good catch! I'll update it!

dangermattic · 2025-09-17T10:51:18Z

	1 Warning
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.

Generated by 🚫 Danger

adalpari · 2025-09-17T10:51:35Z

libs/fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt

                }
+
+                209 -> {
+                    db.execSQL("ALTER TABLE MediaModel ADD FILE_SIZE INTEGER")


When I tested how the library creates the DB column, it looks like even it being a long variable, WellSql uses an INTEGER. So, I've just followed the approach to avoid side problems.

What is the "library" in this context?

WellSql. The library used to manage MySql DB.

wpmobilebot · 2025-09-17T11:12:42Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22216-03b2deb
	Commit	`03b2deb`
	Direct Download	`wordpress-prototype-build-pr22216-03b2deb.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2025-09-17T11:14:19Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22216-03b2deb
	Commit	`03b2deb`
	Direct Download	`jetpack-prototype-build-pr22216-03b2deb.apk`

Note: Google Login is not supported on these builds.

codecov · 2025-09-17T11:22:20Z

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.22%. Comparing base (4560f1f) to head (03b2deb).
⚠️ Report is 3 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...c/network/rest/wpapi/media/MediaRSApiRestClient.kt	16.66%	3 Missing and 2 partials ⚠️
...rdpress/android/fluxc/persistence/WellSqlConfig.kt	33.33%	2 Missing ⚠️
.../org/wordpress/android/fluxc/model/MediaModel.java	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #22216   +/-   ##
=======================================
  Coverage   39.22%   39.22%           
=======================================
  Files        2164     2164           
  Lines      103310   103310           
  Branches    15881    15881           
=======================================
  Hits        40522    40522           
  Misses      59193    59193           
  Partials     3595     3595

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

WordPress/src/main/java/org/wordpress/android/ui/media/MediaSettingsActivity.java

    private SeekBar mImageSizeSeekBarView;
    private Spinner mAlignmentSpinnerView;
    private FloatingActionButton mFabView;
+    private TextView mFileSizeView;


WordPress/src/main/java/org/wordpress/android/ui/media/MediaSettingsActivity.java

    private Spinner mAlignmentSpinnerView;
    private FloatingActionButton mFabView;
+    private TextView mFileSizeView;
+    private TextView mFileSizeLabelView;


…creen

dcalhoun

Testing worked well for me. 🎉 I noted that VideoPress files did not display a file size—is that expected?

VideoPress file

Also, should we address the null annotations before merging?

dcalhoun · 2025-09-18T13:53:08Z

libs/fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt

                }
+
+                209 -> {
+                    db.execSQL("ALTER TABLE MediaModel ADD FILE_SIZE INTEGER")


What is the "library" in this context?

dcalhoun · 2025-09-18T14:07:13Z

WordPress/src/main/java/org/wordpress/android/ui/media/MediaSettingsActivity.java

+            final String[] units = new String[] {
+                    getString(R.string.file_size_in_bytes),
+                    getString(R.string.file_size_in_kilobytes),
+                    getString(R.string.file_size_in_megabytes),
+                    getString(R.string.file_size_in_gigabytes),
+                    getString(R.string.file_size_in_terabytes)
+            };


An aside: is it typical to use lowercase for kB, but uppercase for MB, GB, TB? The divergence seems odd to me.

sonarqubecloud · 2025-09-18T16:48:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari added 5 commits September 17, 2025 11:43

Creating the field in MediaModel

4e8d581

Filling the field in rs requests

f9fc6c6

Adding the field to the db

907f13c

Adding field to the UI

4c3a7f0

Minor refactor

eaec3e0

adalpari requested a review from Copilot September 17, 2025 10:50

Copilot AI reviewed Sep 17, 2025

View reviewed changes

adalpari commented Sep 17, 2025

View reviewed changes

adalpari marked this pull request as ready for review September 17, 2025 10:56

adalpari added the [Type] Task label Sep 17, 2025

github-advanced-security bot found potential problems Sep 17, 2025

View reviewed changes

adalpari requested review from dcalhoun and oguzkocer September 17, 2025 11:26

Merge branch 'trunk' into feature/CMM-628-Add-filesize-to-the-media-s…

7fe4b9d

…creen

adalpari mentioned this pull request Sep 18, 2025

CMM-761: add filesize to the media screen (wp.com sites) #22220

Merged

dcalhoun approved these changes Sep 18, 2025

View reviewed changes

Updating kB to KB

03b2deb

adalpari enabled auto-merge (squash) September 18, 2025 16:48

adalpari merged commit 3e7e021 into trunk Sep 18, 2025
23 of 26 checks passed

adalpari deleted the feature/CMM-628-Add-filesize-to-the-media-screen branch September 18, 2025 17:02

dcalhoun added this to the 26.3 milestone Sep 19, 2025

CMM 628 add filesize to the media screen #22216

CMM 628 add filesize to the media screen #22216

Uh oh!

Conversation

adalpari commented Sep 17, 2025

Description

Testing instructions

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangermattic commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adalpari Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Check notice

Check notice

dcalhoun left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 18, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dangermattic commented Sep 17, 2025 •

edited

Loading

adalpari Sep 18, 2025 •

edited

Loading

wpmobilebot commented Sep 17, 2025 •

edited

Loading

wpmobilebot commented Sep 17, 2025 •

edited

Loading

codecov bot commented Sep 17, 2025 •

edited

Loading