Skip to content

Fix broken reader YouTube embeds #22348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+5 −3
Closed

Fix broken reader YouTube embeds #22348

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderPostRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,12 @@ class ReaderPostRenderer(

// IMPORTANT: use loadDataWithBaseURL() since loadData() may fail
// https://code.google.com/p/android/issues/detail?id=4401
// also important to use null as the baseUrl since onPageFinished
// doesn't appear to fire when it's set to an actual url
// Use android-app:// scheme as baseUrl to set HTTP referrer for YouTube embeds.
// Google requires this for embedded videos to work properly.
// https://developers.google.com/youtube/terms/required-minimum-functionality#set-the-referer
// https://stackoverflow.com/questions/79761743/youtube-video-in-webview-gives-error-code-153-on-android/79809094#79809094
webView.loadDataWithBaseURL(
null,
"https://wordpress.com/reader",
htmlContent,
"text/html",
"UTF-8",
Expand Down