This repository was archived by the owner on Feb 4, 2025. It is now read-only.
🤖 Add backend-driven Dynamic Cards filtering #2935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
justtwago
approved these changes
Jan 3, 2024
Contributor
justtwago
left a comment
justtwago
left a comment
There was a problem hiding this comment.
Awesome work, Antonis! It's nice to move feature flag handling to the backend side 🎉
Tested all the cases from the client PR and it works as described. The code is good to me!
Thank you a lot!
Contributor
|
Proceeding with merging the PR since D133371-code is shipped. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-Android#19870
WordPress-Android PR: wordpress-mobile/WordPress-Android#19877
Description
This PR removes the
remote_feature_flagfrom the response and passes the following params to the dashboard cards endpoint (similar to the feature flags endpoint):device_idplatformbuild_numbermarketing_versionidentifierTo test
Use the wordpress-mobile/WordPress-Android#19877
Note
Please remove the
[PR] Not Ready for Mergelabel and merge after:trunk