Implement workaround for slow likes fetches in Stats #11841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ScoutHarris
approved these changes
Jun 3, 2019
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
This works great Jan, thank you! GTG! (just reminding to change the destination branch if necessary)
1 task
…oading_stub [Stats Refresh] Period Overview chart: show dashes for Likes value
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11657, kinda-ish.
Alright, so this "fixes" the slow Stats summary fetches.
As I explained in the WPKit PR, I tried almost everything I could think of to "fix" this, but this workaround was closest I could get to something reasonable. We could think about a nicer way of handling this in UI in a future update, but I think this should do for now...
To test: