Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Mar 12, 2020

This PR updates Authenticator to use the most recent version of WordPressKit.
Ref. wordpress-mobile/WordPressKit-iOS#232

Do not merge until:

  • WordPressKit Swift 5 migration PR is merged first (above ref.) ✔️
  • WordPressKit release has been published on CocoaPods ✔️
  • this podfile has been updated to point to 4.6.0-beta.6 instead of a branch ✔️

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. Because I merged the previous one, it just needs updating the podspec (which can still stay on beta.5) and update Podfile.lock

@Gio2018 Gio2018 self-requested a review March 13, 2020 20:19
And update the podspec to reflect the correct dependency
@mindgraffiti
Copy link
Contributor Author

Thank you @ScoutHarris and @Gio2018!

@mindgraffiti mindgraffiti merged commit 1e53327 into develop Mar 13, 2020
@mindgraffiti mindgraffiti deleted the issue/update-wpkit-to-4.6.0-beta.6 branch March 13, 2020 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants