This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Update SIWA button appearance #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mindgraffiti
approved these changes
Mar 19, 2020
| /// | ||
| static var linkFieldImage: UIImage { | ||
| return UIImage(named: "icon-url-field", in: bundle, compatibleWith: nil)! | ||
| return UIImage(named: "icon-url-field", in: bundle, compatibleWith: nil) ?? UIImage() |
| let appleButton = WPStyleGuide.appleLoginButton() | ||
| appleButton.addTarget(self, action: #selector(handleAppleButtonTapped), for: .touchDown) | ||
| buttonViewController.stackView?.insertArrangedSubview(appleButton, at: 3) | ||
| buttonViewController.setupTertiaryButtonFor(socialService: .apple, onTap: handleAppleButtonTapped) |
This was referenced Mar 20, 2020
akirk
reviewed
Mar 24, 2020
|
|
||
| let buttonString = NSMutableAttributedString(attachment: googleAttachment) | ||
| let googleTitle = NSLocalizedString(" Continue with Google", comment: "Button title. Tapping begins log in using Google. There is a leading space to separate it from the Google logo.") | ||
| let googleTitle = NSLocalizedString(" Continue with Google", comment: "Button title. Tapping begins log in using Google. There are leading spaces to separate it from the Google logo.") |
There was a problem hiding this comment.
Could we please revert this? It changes translatable strings unnecessarily and whitespace around translations is discouraged and stripped from our systems. What about this?
let googleTitle = " " + NSLocalizedString("Continue with Google", comment: "Button title. Tapping begins log in using Google. There are leading spaces to separate it from the Google logo.")
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #155, wordpress-mobile/WordPress-iOS#13466
Ref: wordpress-mobile/WordPress-iOS#13620
The main goal here is to update the SIWA button to be consistent with the other Login/Signup buttons. However, because Apple has rules about custom SIWA buttons, other parts of the button view had be updated to match. As it happens, @mattmiklic 's Unified Auth design worked perfectly.
So, this change updates:
This can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#13686