UL&S: Navigate to a blank SiteCredentialsViewController #324
Conversation
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Scheme | ||
| LastUpgradeVersion = "1130" | ||
| LastUpgradeVersion = "1150" |
There was a problem hiding this comment.
It updates the pods project file to the latest version. It should fix this warning:
There was a problem hiding this comment.
I tried it again. This doesn't actually fix the warning. Will revert.
| guard let vc = LoginSelfHostedViewController.instantiate(from: .login) else { | ||
| DDLogError("Failed to navigate from LoginEmailViewController to LoginSelfHostedViewController") | ||
| guard let vc = SiteCredentialsViewController.instantiate(from: .siteAddress) else { | ||
| DDLogError("Failed to navigate from SiteAddressViewController to SiteAddressViewController") |
There was a problem hiding this comment.
Maybe this should be:
DDLogError("Failed to navigate from SiteAddressViewController to SiteCredentialsViewController")
| /// Configure the instruction cell. | ||
| /// | ||
| func configureInstructionLabel(_ cell: TextLabelTableViewCell) { | ||
| cell.configureLabel(text: "Enter your account information for pamelanguyen.com", style: .body) |
There was a problem hiding this comment.
Per the design, there is a period at the end of this sentence.
|
@ScoutHarris ready for a second look! The background color override wasn't in place yet. I added it:
|
| /// Rows listed in the order they were created. | ||
| /// | ||
| enum Row { | ||
| case instructions |
There was a problem hiding this comment.
just a thought: unless you are going to have a considerable number of different cases, maybe you could just refer to the constant (TextLabelTableViewCell.reuseIdentifier) since it's already accessible from the same scope?
There was a problem hiding this comment.
There are going to be 5 cases in total, so this enum will expand quite a bit in the next PR. I put the instruction row in so that it proves the table is displaying correctly and populating data.
|
Thanks @ScoutHarris and @Gio2018! |
3 participants
Ref. #322
Testing PR: wordpress-mobile/WordPress-iOS#14450
In this PR, a new view controller,
SiteCredentialsViewController, and the basic UI have been added to the SiteAddress.storyboard. This code should look very similar to theSiteAddressViewController, as they share several of the same methods, UI, and IBOutlets.To test
bundle exec pod install