Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Update accessibility identifiers to unique values #53

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Update accessibility identifiers to unique values #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions WordPressAuthenticator/Signin/LoginEmailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,14 +110,14 @@ open class LoginEmailViewController: LoginViewController, NUXKeyboardResponder {
instructionLabel?.text = WordPressAuthenticator.shared.displayStrings.emailLoginInstructions
}
emailTextField.placeholder = NSLocalizedString("Email address", comment: "Placeholder for a textfield. The user may enter their email address.")
emailTextField.accessibilityIdentifier = "Email address"
emailTextField.accessibilityIdentifier = "Login Email Address"

alternativeLoginLabel?.text = NSLocalizedString("Alternatively:", comment: "String displayed before offering alternative login methods")

let submitButtonTitle = NSLocalizedString("Next", comment: "Title of a button. The text should be capitalized.").localizedCapitalized
submitButton?.setTitle(submitButtonTitle, for: .normal)
submitButton?.setTitle(submitButtonTitle, for: .highlighted)
submitButton?.accessibilityIdentifier = "Next Button"
submitButton?.accessibilityIdentifier = "Login Email Next Button"
}


Expand Down
2 changes: 1 addition & 1 deletion WordPressAuthenticator/Signin/LoginPrologueViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class LoginPrologueViewController: LoginViewController {
let loginTitle = NSLocalizedString("Log In", comment: "Button title. Tapping takes the user to the login form.")
let createTitle = NSLocalizedString("Sign up for WordPress.com", comment: "Button title. Tapping begins the process of creating a WordPress.com account.")

buttonViewController.setupTopButton(title: loginTitle, isPrimary: true, accessibilityIdentifier: "Log In Button") { [weak self] in
buttonViewController.setupTopButton(title: loginTitle, isPrimary: true, accessibilityIdentifier: "Prologue Log In Button") { [weak self] in
self?.loginTapped()
}
buttonViewController.setupBottomButton(title: createTitle, isPrimary: false) { [weak self] in
Expand Down
2 changes: 1 addition & 1 deletion WordPressAuthenticator/Signin/LoginSiteAddressViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class LoginSiteAddressViewController: LoginViewController, NUXKeyboardResponder
let submitButtonTitle = NSLocalizedString("Next", comment: "Title of a button. The text should be capitalized.").localizedCapitalized
submitButton?.setTitle(submitButtonTitle, for: .normal)
submitButton?.setTitle(submitButtonTitle, for: .highlighted)
submitButton?.accessibilityIdentifier = "Next Button"
submitButton?.accessibilityIdentifier = "Site Address Next Button"

let siteAddressHelpTitle = NSLocalizedString("Need help finding your site address?", comment: "A button title.")
siteAddressHelpButton.setTitle(siteAddressHelpTitle, for: .normal)
Expand Down
2 changes: 1 addition & 1 deletion WordPressAuthenticator/Signin/LoginWPComViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class LoginWPComViewController: LoginViewController, NUXKeyboardResponder {
let submitButtonTitle = NSLocalizedString("Next", comment: "Title of a button. The text should be capitalized.").localizedCapitalized
submitButton?.setTitle(submitButtonTitle, for: .normal)
submitButton?.setTitle(submitButtonTitle, for: .highlighted)
submitButton?.accessibilityIdentifier = "Log In Button"
submitButton?.accessibilityIdentifier = "Password Next Button"

let forgotPasswordTitle = NSLocalizedString("Lost your password?", comment: "Title of a button. ")
forgotPasswordButton?.setTitle(forgotPasswordTitle, for: .normal)
Expand Down
4 changes: 2 additions & 2 deletions WordPressAuthenticator/Signup/SignupEmailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ class SignupEmailViewController: LoginViewController, NUXKeyboardResponder {
instructionLabel?.text = NSLocalizedString("To create your new WordPress.com account, please enter your email address.", comment: "Text instructing the user to enter their email address.")

emailField.placeholder = NSLocalizedString("Email address", comment: "Placeholder for a textfield. The user may enter their email address.")
emailField.accessibilityIdentifier = "Email address"
emailField.accessibilityIdentifier = "Signup Email Address"
emailField.contentInsets = WPStyleGuide.edgeInsetForLoginTextFields()

let submitButtonTitle = NSLocalizedString("Next", comment: "Title of a button. The text should be capitalized.").localizedCapitalized
submitButton?.setTitle(submitButtonTitle, for: .normal)
submitButton?.setTitle(submitButtonTitle, for: .highlighted)
submitButton?.accessibilityIdentifier = "Next Button"
submitButton?.accessibilityIdentifier = "Signup Email Next Button"
}

/// Configure the view for an editing state. Should only be called from viewWillAppear
Expand Down